Feature/add properties for repository via j frog cli #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
naveenku-jfrog
commented
Jul 8, 2025
naveenku-jfrog
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
bhanurp
requested changes
Jul 9, 2025
| return | ||
| } | ||
|
|
||
| func (rbd *ReleaseBundleRemoteDeleteCommand) IsNewReleaseBundleApiSupported(artifactoryServiceManager artifactory.ArtifactoryServicesManager) bool { |
Collaborator
There was a problem hiding this comment.
why is this change required?
| const avoidConfirmationMsg = "You can avoid this confirmation message by adding --quiet to the command." | ||
| const ( | ||
| avoidConfirmationMsg = "You can avoid this confirmation message by adding --quiet to the command." | ||
| minimumVersionForSupportingNewReleaseBundleApi = "7.63.2" |
naveenku-jfrog
added
feature request
naveenku-jfrog
added
the
safe to test
bhanurp
reviewed
Jul 10, 2025
| propsRecursive: components.NewBoolFlag(Recursive, "[Default: true] When false, artifacts inside sub-folders in Artifactory will not be affected.", components.WithBoolDefaultValueFalse()), | ||
| propsProps: components.NewStringFlag(props, "[Optional] List of semicolon-separated(;) properties in the form of \"key1=value1;key2=value2;...\". Only artifacts with these properties are affected.", components.SetMandatoryFalse()), | ||
| propsExcludeProps: components.NewStringFlag(excludeProps, "[Optional] List of semicolon-separated(;) properties in the form of \"key1=value1;key2=value2;...\". Only artifacts without the specified properties are affected.", components.SetMandatoryFalse()), | ||
| repoOnly: components.NewBoolFlag(repoOnly, "[Default: true] When false, artifacts inside sub-folders in Artifactory will be affected.", components.WithBoolDefaultValueFalse()), |
Collaborator
There was a problem hiding this comment.
default should be false, there are more users using --repo-only false instead of true
| Exclusions(c.GetStringsArrFlagValue("exclusions")). | ||
| IncludeDirs(c.GetBoolFlagValue("include-dirs")). | ||
| ArchiveEntries(c.GetStringFlagValue("archive-entries")). | ||
| RepoOnly(c.GetBoolTFlagValue("repo-only")). |
Collaborator
There was a problem hiding this comment.
this should be changed based on repo-only default value false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.