Added Maven native implementation using flexpack #3081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrasth
force-pushed
the
mavenFlexpack
branch
from
a1ecb5c to
2920eff
Compare
agrasth
force-pushed
the
mavenFlexpack
branch
from
2920eff to
c02dc3c
Compare
agrasth
force-pushed
the
mavenFlexpack
branch
from
c02dc3c to
15dabf6
Compare
agrasth
force-pushed
the
mavenFlexpack
branch
from
15dabf6 to
78989c5
Compare
agrasth
force-pushed
the
mavenFlexpack
branch
from
78989c5 to
1e5e5c1
Compare
agrasth
added
the
safe to test
github-actions
bot
removed
the
safe to test
agrasth
changed the base branch from
dev-deprecated-please-target-master-directly
to
master
agrasth
added
the
safe to test
github-actions
bot
removed
the
safe to test
utils/buildinfo/buildinfo.go
Outdated
| buildInstance, err := buildInfoService.GetOrCreateBuildWithProject( | ||
| buildInfo.Name, | ||
| buildInfo.Number, | ||
| "", // project key - can be empty for now |
Collaborator
There was a problem hiding this comment.
Shouldn't we pass projectKey that is available with buildInfoService?
Contributor
Author
There was a problem hiding this comment.
Thanks! will add this.
utils/buildinfo/buildinfo.go
Outdated
| // Get deployment repository from configuration | ||
| deployRepo := getDeploymentRepoFromConfig(workingDir) | ||
| if deployRepo == "" { | ||
| deployRepo = "maven-flexpack-local" // fallback |
Collaborator
There was a problem hiding this comment.
We should use Const for storing hardcoded strings.
utils/buildinfo/buildinfo.go
Outdated
| // Also check for POM file (deployed by Maven from project root) | ||
| pomPatterns := []string{ | ||
| "pom.xml", // The original POM file that Maven deployed | ||
| } |
Collaborator
There was a problem hiding this comment.
Why only file inside slice? Are we expecting more files to be added inside it? If no, then no need of slice.
agrasth
force-pushed
the
mavenFlexpack
branch
from
b978b0f to
8fb9220
Compare
agrasth
force-pushed
the
mavenFlexpack
branch
2 times, most recently
from
f75cff3 to
3cfdf8d
Compare
ehl-jf
added
the
safe to test
github-actions
bot
removed
the
safe to test
agrasth
force-pushed
the
mavenFlexpack
branch
from
3cfdf8d to
921aebe
Compare
ehl-jf
added
the
safe to test
github-actions
bot
removed
the
safe to test
agrasth
force-pushed
the
mavenFlexpack
branch
from
73b02d5 to
9ab34a7
Compare
ehl-jf
added
the
safe to test
github-actions
bot
removed
the
safe to test
- Removed duplicate import of jfrog-cli-core/v2/utils/log - The file already uses jfrog-client-go/utils/log package - This fixes the build error with redeclared log package
agrasth
force-pushed
the
mavenFlexpack
branch
from
9ab34a7 to
32b305e
Compare
ehl-jf
added
the
safe to test
github-actions
bot
removed
the
safe to test
fluxxBot
approved these changes
Oct 4, 2025
github-actions
bot
removed
the
safe to test
github-actions
bot
removed
the
safe to test
github-actions
bot
removed
the
safe to test
github-actions
bot
removed
the
safe to test
github-actions
bot
removed
the
safe to test
agrasth
added
the
safe to test
github-actions
bot
removed
the
safe to test
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....Add FlexPack Maven Support to JFrog CLI
Summary
Implements native FlexPack Maven support in JFrog CLI, leveraging the FlexPack implementation from
build-info-goto provide enhanced build info collection and artifact management for Maven projects.Changes Made
FlexPack Integration
maven_test.gobuild-info-goFlexPack implementation for native Maven supportTest Enhancements
Dependencies
build-info-gorepositoryJFROG_RUN_NATIVE=trueenvironment variable for FlexPack executionFiles Modified
jfrog-cli/maven_test.go- Added FlexPack test coverage and fixed linting issues