Conversation
Uncomment OLLAMA_UPSTREAM env var so keyring-proxy registers the Ollama vendor and routes bot LLM requests to the local Ollama instance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OpenClaw auto-discovery looks for exact "openai"/"gemini" provider names but BotMaker creates -proxy suffixed names, so memorySearch always failed. Now the template generator produces an explicit memorySearch section with the correct embedding model per provider, or disables it for providers without /embeddings support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds explicit memorySearch configuration generation so OpenClaw can use embeddings through the keyring-proxy (or disable memory search when embeddings aren’t supported), plus updates supporting docs and local dev defaults.
Changes:
- Introduces
EMBEDDING_MODELSmapping andgetMemorySearchConfig()to generate/disablememorySearchinopenclaw.json. - Updates template generation to include
memorySearchunder agent defaults and adds Vitest coverage. - Enables
OLLAMA_UPSTREAMby default indocker-compose.ymland adds aCLAUDE.mdrepo guide.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/bots/templates.ts | Adds embedding-model map + memorySearch config builder and wires it into generated OpenClaw config |
| src/bots/templates.test.ts | Adds unit tests for getMemorySearchConfig and asserts memorySearch in generated configs |
| docker-compose.yml | Turns on Ollama upstream env var by default |
| CLAUDE.md | Adds repository guidance and architectural notes (including memorySearch rationale) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.