Conversation
- Use nullish coalescing where safe, suppress where || is intentional - Replace `as number` cast with Number() conversion in server.ts - Use T[] array syntax instead of Array<T> in CaddyService - Add explicit Record type to fix no-unnecessary-condition lint error Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses ESLint/type-safety issues across configuration loading, server startup logic, and the Caddy integration service to keep the codebase compliant with the current lint rules without changing intended behavior.
Changes:
- Add an explicit
Recordtype for Docker network inspection results to satisfyno-unnecessary-condition. - Replace a TypeScript
as numbercast with an explicitNumber()conversion when restoring Caddy routes on startup. - Normalize array type syntax in
CaddyService.restoreRoutestoT[]and document an intentional||usage in config with an ESLint suppression.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/services/CaddyService.ts | Tightens types around Docker network inspection and updates array type syntax for restoreRoutes. |
| src/server.ts | Makes port handling explicit during Caddy route restoration by converting to number via Number(). |
| src/config.ts | Suppresses prefer-nullish-coalescing where ` |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as numbercast with Number() conversion in server.ts