Skip to content

feat/small-refactors#5

Merged
jggoebel merged 7 commits intojggoebel:masterfrom
TitusKirch:feat/small-refactors
Sep 8, 2024
Merged

feat/small-refactors#5
jggoebel merged 7 commits intojggoebel:masterfrom
TitusKirch:feat/small-refactors

Conversation

@TitusKirch
Copy link
Copy Markdown
Contributor

I have done a few small things in my repo. You may be interested in them. In the PR I do the following:

fix:

  • adjust condition to show duplicate message only if command was found

feat:

  • add meta attributes to packages.json

refactor:

  • rename project from hobbyfarm-ui to @jggoebel/bashbrawl
  • remove all usages of "awaits" that has no effect
  • format and lint code

build:

  • minor and patch updates of dependencies
    • there are some major updates open, but I have left them out here due to breaking changes

@jggoebel jggoebel merged commit fab5c7d into jggoebel:master Sep 8, 2024
@jggoebel
Copy link
Copy Markdown
Owner

jggoebel commented Sep 8, 2024

Great work!

@jggoebel
Copy link
Copy Markdown
Owner

jggoebel commented Sep 9, 2024

I had to re-add await this.commandFn(command, params); in line 753, otherwise the user can input things before a command has been executed. I updated the method definition so the IDE does not annotate this as an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants