Update readable-stream#2
Merged
Merged
Conversation
Owner
|
Thanks, looks good! |
Owner
|
In the future I'd prefer PRs didn't include version number changes. |
Collaborator
Author
Got it |
diegocr
reviewed
Sep 28, 2018
| "dependencies": { | ||
| "inherits": "^2.0.1", | ||
| "readable-stream": "^2.0.5" | ||
| "readable-stream": "^3.0.2" |
There was a problem hiding this comment.
@jhiesey I think this could create "a little mess" within videostream.js etc, I.e. readable-stream should ideally also get upgraded on mediasource & mp4-stream (?)
$ npm ls readable-stream
videostream@2.6.0
+-- mediasource@2.2.2
| `-- readable-stream@2.3.6
+-- mp4-stream@2.0.3
| `-- readable-stream@2.3.6
+-- range-slice-stream@2.0.0
| `-- readable-stream@3.0.3
`-- readable-stream@3.0.3
Collaborator
Author
There was a problem hiding this comment.
I know
I'm trying to help all package involved in webtorrent to try and update readable-stream to v3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I don't directly use
range-slice-streambut one of your dependency is outdated (readable-stream v2)I have another package that uses readable-stream v3 and your v2 is making lots of duplicated code
I updated your code to use es6 that is compatible with latest node LTS ( node v6 )
therefore i removed inherits and replaced it with class extends
And now you can't call
RangeSliceStream()withoutnewAnd readable-stream made a major update so i thought a new major version where in place here to