Switch statement indentation

[jhaber]

I've noticed a few issues with indentation related to switch statements (I can open separate issues if you'd prefer). I was running these examples with:
prettier --write "Example.java" --print-width 90 (I also tried with #255 applied but observed the same behavior)

The first issue seems to manifest when there is a comment on the line preceding the default case. In this case, the default keyword gets indented incorrectly (removing the comment fixes the issue).

Input:

public class Example {

  public int method() {
    switch ("abc") {
      case "a":
        return 1;
      case "b":
        return 2;
      case "c":
        return 3;
      // default case
      default:
        return 3;
    }
  }
}

Output:

public class Example {

  public int method() {
    switch ("abc") {
      case "a":
        return 1;
      case "b":
        return 2;
      case "c":
        return 3;
      // default case
        default:
        return 3;
    }
  }
}

The second issue is when there is a comment on one of the other case labels. When this happens, the whole switch statement appears to get mangled (removing the comment also fixes this issue).

Input:

public class Example {

  public int method() {
    switch ("abc") {
      case "a":
        return 1;
      case "b":
        return 2;
      // case c
      case "c":
        return 3;
      default:
        return 3;
    }
  }
}

Output:

public class Example {

  public int method() {
    switch ("abc") { case "a": return 1; case "b": return 2; // case c
        case "c": return 3; default: return 3; }
  }
}

[jhaber]

My team is still just experimenting with prettier-java on some of our repos, but if we decide to move forward with it we could try to PR fixes for issues like this

[clementdessoude]

Thank you for reporting this. We have some issues with the way we handle comments right now. It is at the top of my todo list to refactor it so that we can deal with all of these issues (this one, #262, #259, #270)

[clementdessoude]

I have something (a POC) that seems working based on a previous work from @Shaolans (it attaches comments on the nodes of the CST, instead of the tokens), but it needs some refinements and optimizations

[pascalgrimaud]

Adding a bounty on this