Indent after comment line

[benjavalero]

After a comment line, if the block below is formatted, it gets unnecessarily indented.

Input:

// 1 result in DB by no type
Mockito.when(replacementRepository.findRandomArticleIdsToReview(Mockito.any(PageRequest.class)))
        .thenReturn(new ArrayList<>(Collections.singletonList(randomId2)));

Output (0.4.0):

// 1 result in DB by no type
    Mockito.when(
        replacementRepository.findRandomArticleIdsToReview(Mockito.any(PageRequest.class))
    ).thenReturn(new ArrayList<>(Collections.singletonList(randomId2)));

Expected output:

// 1 result in DB by no type
Mockito.when(
    replacementRepository.findRandomArticleIdsToReview(Mockito.any(PageRequest.class))
).thenReturn(new ArrayList<>(Collections.singletonList(randomId2)));

[jhaber]

Might be worth re-testing on master since 0.4.0 doesn't include #278

[murdos]

@clement26695: BTW it would nice to do a new release, since a lot of interesting things has landed in master 😉

[benjavalero]

Might be worth re-testing on master since 0.4.0 doesn't include #278

I think I have retested against master and still get the same behaviour.

[clementdessoude]

I'll try to have a look when I have some time, probably next weekend.

@murdos it was the plan to do one last weekend, but I got some computer issues unfortunately. I'll try to do one this weekend too !

[clementdessoude]

Just tested with master branch. When I try to format this :

class T {
	void t() {
		// 1 result in DB by no type
Mockito.when(replacementRepository.findRandomArticleIdsToReview(Mockito.any(PageRequest.class)))
.thenReturn(new ArrayList<>(Collections.singletonList(randomId2)));
	}
}

I got this:

class T {

  void t() {
    // 1 result in DB by no type
    Mockito
      .when(
        replacementRepository.findRandomArticleIdsToReview(
          Mockito.any(PageRequest.class)
        )
      )
      .thenReturn(new ArrayList<>(Collections.singletonList(randomId2)));
  }
}

with these options:

--print-width 80
--tab-width 2

[benjavalero]

Sorry, I wasn't using the master version of java-parser.

[clementdessoude]

Don't be sorry, it is really helpful to have your feedbacks! And we should improve our docs :)