Ugly formatting of a method reference of an expression

[boris-petrov]

Prettier-Java 2.7.3

Playground link

--print-width 100

Input:

public abstract class Foo implements MyInterface {
	@Override
	public String foo() {
		Iterable<Map.Entry<String, Object>> iterable = (sortMapKeys && value.size() > 1
			? value.entrySet().stream().sorted(Map.Entry.comparingByKey())
			: value.entrySet().stream())::iterator;
	}
}

Output:

public abstract class Foo implements MyInterface {

	@Override
	public String foo() {
		Iterable<Map.Entry<String, Object>> iterable = (sortMapKeys && value.size() > 1
				? value.entrySet().stream().sorted(Map.Entry.comparingByKey())
				: value.entrySet().stream())::iterator;
	}
}

Expected behavior:
Unsure how but prettier. 😄 Perhaps:

Iterable<Map.Entry<String, Object>> iterable = (
	sortMapKeys && value.size() > 1
		? value.entrySet().stream().sorted(Map.Entry.comparingByKey())
		: value.entrySet().stream()
	)
	::iterator;

[boris-petrov]

A similar issue is with method references after a long chain of methods:

public abstract class Foo implements MyInterface {
	@Override
	public String foo() {
		x.stream().stream().stream().stream()::methodReference;
	}
}

Results in:

public abstract class Foo implements MyInterface {

	@Override
	public String foo() {
		x
			.stream()
			.stream()
			.stream()
			.stream()::methodReference;
	}
}

Which I believe is not the best way of formatting this. For me this is much prettier (and correct):

public abstract class Foo implements MyInterface {

	@Override
	public String foo() {
		x
			.stream()
			.stream()
			.stream()
			.stream()
			::methodReference;
	}
}

Playground link

[jtkiesel]

@boris-petrov #800 fixed the issues you mentioned in the issue description (which was an issue with parentheses expressions in general). However, I've kept the behavior of method references in a regular chain alone (the behavior you mentioned in your comment). At the moment I've been treating method references similarly to field references. In my opinion, a method reference is more similar to a field reference than to a method invocation (in JavaScript, the only way to reference a method is to access it like a field). If you feel strongly about this, feel free to open a new issue for that behavior and we can continue to discuss and collect others' feedback.

[boris-petrov]

@jtkiesel thanks for fixing this and for the discussion!

You're right that Prettier for JavaScript does the same - so in that sense let's leave it as you've done it to follow the original Prettier as much as possible.

Thanks!