Format issue with long concatenated strings since 2.7.5+

[DanielFran]

Prettier-Java 2.8.0

https://github.com/jhipster/jhipster-bom/blob/main/.prettierrc

# Prettier configuration

printWidth: 140
singleQuote: true
tabWidth: 2
useTabs: false

# js and ts rules:
arrowParens: avoid

plugins:
  - prettier-plugin-java

# java rules:
overrides:
  - files: '*.java'
    options:
      tabWidth: 4

Input:

// code snippet
    void testToString() {
        filter.setEquals(value);
        filter.setNotEquals(value);
        filter.setSpecified(true);
        filter.setIn(new LinkedList<>());
        filter.setNotIn(new LinkedList<>());
        filter.setGreaterThan(value);
        filter.setLessThan(value);
        filter.setGreaterThanOrEqual(value);
        filter.setLessThanOrEqual(value);
        String str = value.toString();
        assertThat(filter.toString()).isEqualTo(
            "BigDecimalFilter [equals=" +
            str +
            ", notEquals=" +
            str +
            ", specified=true, in=[], notIn=[], greaterThan=" +
            str +
            ", lessThan=" +
            str +
            ", greaterThanOrEqual=" +
            str +
            ", lessThanOrEqual=" +
            str +
            "]"
        );
    }

Output:

// code snippet
    void testToString() {
        filter.setEquals(value);
        filter.setNotEquals(value);
        filter.setSpecified(true);
        filter.setIn(new LinkedList<>());
        filter.setNotIn(new LinkedList<>());
        filter.setGreaterThan(value);
        filter.setLessThan(value);
        filter.setGreaterThanOrEqual(value);
        filter.setLessThanOrEqual(value);
        String str = value.toString();
        assertThat(filter.toString()).isEqualTo(
            "BigDecimalFilter [equals=" +
                str +
                ", notEquals=" +
                str +
                ", specified=true, in=[], notIn=[], greaterThan=" +
                str +
                ", lessThan=" +
                str +
                ", greaterThanOrEqual=" +
                str +
                ", lessThanOrEqual=" +
                str +
                "]"
        );
    }

Expected behavior:
No impact with long string concatenation
See jhipster/jhipster-bom#1792

[DanielFran]

@jtkiesel Not sure if it is correct behaviour or not.

We have several examples like:

Input:

    void testUsingDurationTypeWithAllFilters() throws IllegalAccessException, IllegalArgumentException, InvocationTargetException {
        DurationFilter testDuration = (DurationFilter) new ConditionTestHelper(
            rangeFilterSetters,
            Arrays.asList(),
            generalFilterSetters,
            true
        ).buildRangeConditions(new DurationFilter(), TEST_DURATION);
        setupBuilder(testDuration);
        assertConditionBuild(
            "c.time_to_go > '21600000' AND c.time_to_go < '21600000' AND c.time_to_go >= '21600000' " +
            "AND c.time_to_go <= '21600000' AND c.time_to_go = '21600000' AND c.time_to_go != '21600000' A" +
            "ND c.time_to_go IN ('21600000') AND c.time_to_go NOT IN ('21600000') AND c.time_to_go IS NOT NULL"
        );
    }

Output:

    void testUsingDurationTypeWithAllFilters() throws IllegalAccessException, IllegalArgumentException, InvocationTargetException {
        DurationFilter testDuration = (DurationFilter) new ConditionTestHelper(
            rangeFilterSetters,
            Arrays.asList(),
            generalFilterSetters,
            true
        ).buildRangeConditions(new DurationFilter(), TEST_DURATION);
        setupBuilder(testDuration);
        assertConditionBuild(
            "c.time_to_go > '21600000' AND c.time_to_go < '21600000' AND c.time_to_go >= '21600000' " +
                "AND c.time_to_go <= '21600000' AND c.time_to_go = '21600000' AND c.time_to_go != '21600000' A" +
                "ND c.time_to_go IN ('21600000') AND c.time_to_go NOT IN ('21600000') AND c.time_to_go IS NOT NULL"
        );
    }

[murdos]

The new behavior seems correct and makes sense IMO.

[jtkiesel]

This change was made in #774 to fix #761 and to align more closely with Prettier JavaScript/TypeScript. Specifically, this change indented binary expressions within lists (such as argument lists), to help make it clear where one list element (argument) ends and the next begins. For example:

var a = b(
  "long text text text text text text " +
  "text text text text text text" +
  "something",
  c
);

vs

var a = b(
  "long text text text text text text " +
    "text text text text text text" +
    "something",
  c
);

Playground links for this example:

• Java
• TypeScript

[DanielFran]

Thanks @jtkiesel for the confirmation.
Closing the ticket