Fix formatComment to keep stable reformating and add comments unit tests#280
Merged
clementdessoude merged 2 commits intojhipster:masterfrom Oct 15, 2019
Merged
Conversation
|
👍 thanks for the quick fix |
|
@clement26695 another suggestion. Take for example this method definition. Currently it gets formatted as So the space before My barbaric temporary fix |
Shaolans
reviewed
Oct 15, 2019
| */ | ||
| rowKeyToIndex = Maps.indexMap(rowList); | ||
| rowKeyToIndex = | ||
| Maps.indexMap(rowList); |
c38fce0 to
a8d0070
Compare
Contributor
Author
|
I will keep it in mind @lppedd ! I prefer to merge this as it is better than that we have right now but will try to find time to improve this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #279
As discussed in #279, it is impossible to know what is inside a block comment, and how it could be reformatted. So, as Prettier in JS, let's keep the original comment and its indentation when the comment is not JavaDoc (see https://prettier.io/docs/en/rationale.html#comments)