Better display of localVariableDeclarationStatement modifiers#283
Merged
clementdessoude merged 1 commit intojhipster:masterfrom Oct 15, 2019
Merged
Conversation
|
@clement26695 thank you! |
Contributor
Author
|
This class CLassWithEnum {
public boolean localVariableDeclarationWhichBreak() {
@Nullable
final BackupStatus lastStatus = BackupStatus.fromDbValue(backupRepository.aVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongFunctionNameWhichGoesOverThePrintWidth(myParam));
final BackupStatus lastStatus = BackupStatus.fromDbValue(backupRepository.aVeryLongFunctionNameWhichGoesOverThePrintWidth(myParam, myParam, myParam, myParam, myParam, myParam));
}
}would be printed like this: class CLassWithEnum {
public boolean localVariableDeclarationWhichBreak() {
@Nullable
final BackupStatus lastStatus = BackupStatus.fromDbValue(
backupRepository.aVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongFunctionNameWhichGoesOverThePrintWidth(
myParam
)
);
final BackupStatus lastStatus = BackupStatus.fromDbValue(
backupRepository.aVeryLongFunctionNameWhichGoesOverThePrintWidth(
myParam,
myParam,
myParam,
myParam,
myParam,
myParam
)
);
}
} |
|
@clement26695 that's perfect imho. |
|
@clement26695 morning! Maybe a bit OT, but I wanted to know your opinion. How would you see it formatted? Like the local variable above? Because that's how it is now. Honestly I'd say something like Looks much more clear on the eye. And in case of nested expressions, it would become Btw, your changes works fine, I'm already using them. |
Shaolans
approved these changes
Oct 15, 2019
Contributor
Author
|
FYI, I tried to improve this behavior in #255. I tried to be close to the Prettier JS behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #282
@lppedd, this would now be formatted like this: