docs: create Docusaurus website#628
Conversation
clementdessoude
left a comment
clementdessoude
left a comment
There was a problem hiding this comment.
Waouh, looks great ! The playground worked fine on Google Chrome but does not seems to work on Firefox, do you know why ?
| <label title="Print trailing commas wherever possible when multi-line."> | ||
| --trailing-comma{" "} | ||
| <select | ||
| disabled={true} // this option isn't seen by prettier-plugin-java when passed programmatically |
There was a problem hiding this comment.
It's strange that the other options are working but not this one, I wonder what causes this issue 🤔
There was a problem hiding this comment.
Figured this out -- just had to add trailingComma as an option in options.js.
@clementdessoude Hmm. Which version of Firefox? I tried it on the latest version for macOS (121.0.1) and it seemed to work properly. For what it's worth, I also tried it on Safari and it seemed to work well. |
jtkiesel
force-pushed
the
docs/create-website
branch
4 times, most recently
from
db8cffd to
da3611f
Compare
|
Pushed an update that implements a "state hash" feature on the playground (very similar to the one on Prettier's playground), which enables the sharing of links to the playground with the code and all options persisted. |
I'm on Firefox 121.0.1 (it seems that it is the latest version) 
As you see in the screenshot, I don't see any code in the formatted section. I don't understand why for the moment, but it seems that the width property is not taken into account for the second editor :/ 
|
jtkiesel
force-pushed
the
docs/create-website
branch
from
da3611f to
da21b6c
Compare
|
@clementdessoude Thanks for the screenshots! I realize now that when I opened the website in Firefox, I had it open in a small window, so the editors were rendered on top of each other, rather than next to each other, which happened to work. Once I expanded my browser window, I also saw the issue. I just pushed a fix. For some reason, on Firefox |
|
@clementdessoude Thank you for merging this! When you have a moment, could you follow the deployment steps on a direct clone (not a fork) of this repo? Doing that will create a |
|
It's done :) |
|
@clementdessoude Thanks! Looks like it worked. 🎉 As a heads up, in order for the website to use the latest version of the plugin (in the playground), those deployment steps should be run (following a local build of the plugin) after every release of the plugin. I'm not sure if it's possible to automate that process? If you use the deploy.sh script, perhaps we can/should add it to that? |
2 participants
What changed with this PR:
Prettier Java now has a Docusaurus website, including an interactive playground that allows users to see how it works. I am currently self-hosting it here.
I have made this a draft PR because the playground currently depends on #616 being merged first, or else #462 prevents it from working properly (that issue seems to have been fixed by newer Chevrotain versions).Relative issues or prs:
Closes #193