Skip to content

fix: add es5 as trailingComma option #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clementdessoude merged 1 commit into from
Mar 24, 2024
Merged

fix: add es5 as trailingComma option #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/prettier-plugin-java/src/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export default {
type: "choice",
category: "Java",
default: "all",
choices: ["all", "none"],
choices: ["all", "es5", "none"],
description: "Print trailing commas wherever possible when multi-line."
}
};
10 changes: 6 additions & 4 deletions website/src/pages/playground/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ interface State {
}

enum TrailingComma {
None = "none",
All = "all"
All = "all",
Es5 = "es5",
None = "none"
}

const codeSample = `public interface MyInterface {
Expand Down Expand Up @@ -144,8 +145,9 @@ function Inner() {
setTrailingComma(event.target.value as TrailingComma)
}
>
<option>all</option>
<option>none</option>
{Object.values(TrailingComma).map(option => (
<option>{option}</option>
))}
</select>
</label>
</details>
Expand Down