Skip to content

Conversation

@jiaweing
Copy link
Owner

@jiaweing jiaweing commented Jan 11, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the pnpm dependencies of this project.

Snyk changed the following file(s):

  • packages/shadcn/package.json
⚠️ Warning
Failed to update the pnpm-lock.yaml, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-MODELCONTEXTPROTOCOLSDK-14871802
  828  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)


Note

Upgrades dependency in packages/shadcn/package.json.

  • Bumps @modelcontextprotocol/sdk from ^1.17.2 to ^1.25.2

Written by Cursor Bugbot for commit 84493c2. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Jan 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
ui Error Error Jan 11, 2026 10:41am

@coderabbitai
Copy link

coderabbitai bot commented Jan 11, 2026

Important

Review skipped

Ignore keyword(s) in the title.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link

Summary of Changes

Hello @jiaweing, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the @modelcontextprotocol/sdk dependency. The primary goal is to mitigate a high-severity Regular Expression Denial of Service (ReDoS) vulnerability present in the older version of the SDK. A manual update to the pnpm-lock.yaml file is required to complete the fix.

Highlights

  • Dependency Upgrade: Upgraded the @modelcontextprotocol/sdk dependency from version 1.17.2 to 1.25.2.
  • Security Fix: This upgrade addresses a high-severity Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-MODELCONTEXTPROTOCOLSDK-14871802) found in the @modelcontextprotocol/sdk package.
  • Automated PR: This pull request was automatically generated by Snyk to remediate the identified vulnerability.
  • Manual Action Required: The pnpm-lock.yaml file could not be automatically updated and requires manual intervention before merging.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request from Snyk upgrades @modelcontextprotocol/sdk to version 1.25.2 to resolve a high-severity ReDoS vulnerability. The version change in package.json is correct. However, the PR description notes that the pnpm-lock.yaml file failed to update. This is a critical issue that must be resolved before merging. Please run pnpm install to update the lock file and include it in this pull request to ensure the security fix is applied correctly across all environments.

"@babel/preset-typescript": "^7.27.1",
"@dotenvx/dotenvx": "^1.48.4",
"@modelcontextprotocol/sdk": "^1.17.2",
"@modelcontextprotocol/sdk": "^1.25.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While this dependency update is necessary to fix a security vulnerability, the pnpm-lock.yaml file has not been updated. As the PR description warns, this step failed. To complete this change, you must run pnpm install to regenerate the lock file and commit the updated pnpm-lock.yaml. Merging without the lock file update will likely leave the project vulnerable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants