verify argument in calls to requests library

[matt-couchman]

Would it make sense to create a 'verify' key value pair in the config that is passed to calls to requests.post() and requests.get()?

[tjelvar-olsson]

Hi Matt,

Could you give some more background as to what problem you are encountering, and where in the code things are currently failing?

Best,
Tjelvar

[matt-couchman]

Hi Tjelvar, Its not failing as such so it’s a suggestion rather than an issue. Because the verify arguments to requests.get() and requests.put() were set to false each time that they were called, a warning was added to the log to say that it was an insecure transaction. Its not a big deal as they are just warnings but I thought that if it was simple to reduce the warnings that would be one less thing to worry about when there is something more significant happening. Cheers, Matt. From: Tjelvar Olsson ***@***.***> Sent: 21 July 2021 06:11 To: jic-dtool/dtool-lookup-server ***@***.***> Cc: Matthew Couchman (JIC) ***@***.***>; Author ***@***.***> Subject: Re: [jic-dtool/dtool-lookup-server] verify argument in calls to requests library (#22) Hi Matt, Could you give some more background as to what problem you are encountering, and where in the code things are currently failing? Best, Tjelvar — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#22 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AECUDEU5XYKZ2PB7JTEPAB3TYZJGDANCNFSM5AVMQA3Q>.

[tjelvar-olsson]

Hi Matt,

I'm assuming that you are referring to https://github.com/jic-dtool/dtool-lookup-server/blob/master/registration_utils/register.py. This is just a helper script to make registering datasets in batch easier. It is not fundamental to the dtool-lookup-server.

I think you could safely copy this script and edit it to make it suit your purposes better. If you make changes that you think would be useful more generally I would be happy to review a pull request.

Best,
Tjelvar