Added testcase for: Controller (Xbox One For Windows)#2
Open
JoergAtGithub wants to merge 9 commits intojkcmusork:get-descriptorfrom
Open
Added testcase for: Controller (Xbox One For Windows)#2JoergAtGithub wants to merge 9 commits intojkcmusork:get-descriptorfrom
JoergAtGithub wants to merge 9 commits intojkcmusork:get-descriptorfrom
Conversation
…ibusb#497) Commit 5c9f147 (libusb#432) replaced a call to strdup with an explicit memcpy to a buffer on the stack. However, it incorrectly used the buffer size, instead of the clamped uevent length, as the argument to memcpy, resulting in reads past the end of uevent: Fix this by using uevent_len as the argument to memcpy. Calling strndupa was considered but abandoned, as it is not standard. Fixes: 5c9f147 (libusb#432) Fixes: 4779d63
Which has multiple child collections in one Input report
- effectively used to run (unit)tests on Windows with ASAN checks;
- fix for incorrect collection sorting and final bit padding;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a testcase, using the data of the Xbox controller you provided, which fails with the original get-descriptor code, but passes with the changes of libusb#501