Conversation
awarecan
reviewed
Oct 24, 2018
nest/nest.py
Outdated
| """ | ||
| Cancel estimated arrival winow. | ||
| """ | ||
| self._set_eta(trip_id, int(0), datetime.datetime.now()) |
Collaborator
There was a problem hiding this comment.
self._set_eta(trip_id, int(0), None)|
|
||
| data = {'trip_id': trip_id, | ||
| 'estimated_arrival_window_begin': eta_begin, | ||
| 'estimated_arrival_window_end': eta_end} |
Collaborator
There was a problem hiding this comment.
data = {'trip_id': trip_id,
'estimated_arrival_window_begin': eta_begin}
if eta_end is not None:
data[estimated_arrival_window_end] = eta_end
Collaborator
Author
There was a problem hiding this comment.
I confirmed that estimated_arrival_window_end must be included even if estimated_arrival_window_begin is set to int(0)
Collaborator
Author
|
Should be good now. I've confirmed against a WIP PR for HASS too, just need to merge this and publish to PyPi, then PR to HASS can be submitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.