Skip to content

add ROM file selection to upgrade dialog#104

Merged
jkotlinski merged 1 commit into
jkotlinski:masterfrom
noahlemen:master
Oct 19, 2025
Merged

add ROM file selection to upgrade dialog#104
jkotlinski merged 1 commit into
jkotlinski:masterfrom
noahlemen:master

Conversation

@noahlemen
Copy link
Copy Markdown
Contributor

use case

allows upgrading to arbitrary lsdj version instead of latest experimental or stable (e.g., 4.7.3 to 5.0.3) while preserving custom kits, fonts, and palettes.

testing

successfully tested upgrading from patched lsdj 7.0.2 to 9.4.0 with custom sample kits, verified that custom sample kits persisted

note: palette count mismatches between ROM versions can cause import to fail. in my actual use case (4.7.3 to 5.0.3), i temporarily commented out the palette import check to complete the upgrade. future enhancement could make palette import optional when count mismatches are detected.

changes

  • adds "Select ROM file..." button to ROM upgrade dialog
  • validates file size matches expected ROM size
  • reuses existing import logic for kits, fonts, and palettes

@jkotlinski
Copy link
Copy Markdown
Owner

Looks good! Thank you for contributing!

@jkotlinski jkotlinski merged commit f6a2d01 into jkotlinski:master Oct 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants