Thread safety issues

[SLaks]

EncryptedType/EncryptedType/EncryptedTypeAttribute.cs

Line 40 in 36d96ec

lock (_sharedKeyServer)

This lock is completely useless.

• You're locking on a writable field, so you may lock on different values at different times.
• You're locking on a publicly visible value, so callers can introduce race conditions if they also lock on it.
• Reference-type (pointer-sized) field writes are atomic anyway, so there is no risk here.

[SLaks]

Elsewhere in that file: Dictionary is not thread-safe.

You should replace your ductionaries with ConcurrentDictionary, and use its atomic mutation methods.

In general, thread-safe code should never consume a mutable object or writable field twice in the same place, because it can change in between.