Externalisation of ini config file#45
Conversation
php-maven information
…xify the previous pull request)
|
Thanks! Really appreciate the pull request(s). It may take a few days for me to review and merge. I will let you know if I have questions. |
|
Hi! Is there a problem with my request? |
|
I see how some of these changes could be useful for your deployment. I am not by any means a leader of this project, but one of the aspects that attracted me to it was the simplicity: concise code and freedom. I personally wouldn't be interested in the use of maven in the master branch with this project, as I would like the freedom to use whatever I want for build management (or nothing at all). |
|
Ok it's a mistake from me. In fact, on my project I'm using PHP-maven and my pull request is polluted. However, my modification about ini configuration is independent of the use of PHP-maven. Do you want that I push a clean pull request with the right code without PHP-maven context? |
|
That would be ideal
|
|
I am also uncertain what you have done to externalize the "ini config file". You're able to set the path to a config resource any path you want already. Some examples of what you have done allows you to do differently would be nice. |
|
@lcotonea If you'd like to resubmit the pull request or provide an example per the last comment that would help. Thanks for this pull request. |
|
@jmathai I hope to do that closely. |
Hi!
To simplify our deployment, we need to have the ini config file in an external directory. This directory must:
So we have decided to use the include_path variable value to do that.
The pulled code contains a code hack in EpiConfig.php on the load method. When we search the ini config file, we firstly scan all directories present in the include_path, and after that we scan the directory given by Epi mechanism (Epi::getPath).
Note: commits #5e038e9 and #5e2aa7a is a rollback of commits #0d0ce39, #2d6f439 and #2699df2
Best regards
L.C.