Add support for .netstandard2.1#101
Merged
springcomp merged 4 commits intojmespath-community:masterfrom Apr 6, 2024
Merged
Conversation
…xisting frameworks remain supported.
To keep .netstandard1.3 support the generated GplexBuffers and ShiftReducePareser are checked in with a few minor conditional changes. For net45 and standard 2.1 the generated files will be use, for netstandard 1.3 the modified files (which normally won't change unless YaccLexTools changes them).
Closed
springcomp
requested changes
Apr 5, 2024
Make PubhbackQueue internal Remove tabs from appveyor.yml Code consistency for csproj
Collaborator
|
Awesome contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to #100
There are 2 parts.
This part simply adds netstandard2.1 as an additional multi-target framework.
Though this removes the vulnerabilities from netstandard1.3, the package has a dependency on gppg/gplex which remains dependent on netstandard1.3
The current gppg/gplex dependency is no longer maintained. Migrating to YaccLexTools provides several benefits.
The first part is pretty straightforward as it only needs to add netstandard2.1 as another framework target.
The second part is more involved. In particular as
dotnet-yltdoesn't support netstandard1.3.The YaccLexTool generates the following files:
The last 2 are basically just runtime support and not related to the
.lexand.ydefinitions.Both
GplexBuffersandShiftReduceParserCodeare using someExceptionconstructors that are not present in netstandard1.3.The generated files have been checked in into the net13 folder and slightly modified to make them compile with 1.3.
The build process will use the generated files for net45 and netstandard 2.1 and use the modified files for 1.3.
This build complexity was chosen to remain compatible with netstandard 1.3.
If netstandard 1.3 is no longer required then this
net13subfolder can be removed.The following test suites have been run successfully:
I only added the creation of the netstandard 2.1 package to the
appveyor.yml. It makes some references toAny CPUwhich seems outdated, but I don't know the build environment that is used and therefore didn't want to change that.The result of this PR is that is now supports
netstandard2.1,net45, andnetstandard1.3and has no longer any dependencies on 3rd party packages in its runtime.