Skip to content

Conversation

@LasneF
Copy link
Contributor

@LasneF LasneF commented May 18, 2015

add a osgi compatible manifest so that the embedded-jmxtrans can be use in a osgi enviroment
this create a manifest that look like that

Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven Bundle Plugin
Built-By: kdeveloper
Build-Jdk: 1.8.0_40
Bnd-LastModified: 1431955631126
Bundle-Description: In process JMX metrics exporter
Bundle-License: http://www.opensource.org/licenses/mit-license.php
Bundle-ManifestVersion: 2
Bundle-Name: embedded-jmxtrans
Bundle-SymbolicName: embedded-jmxtrans
Bundle-Version: 1.0.16.SNAPSHOT
Export-Package: org.jmxtrans.embedded;uses:="javax.annotation,javax.ma
nagement";version="1.0.16",org.jmxtrans.embedded.config;uses:="com.fa
sterxml.jackson.databind,javax.annotation,javax.management,org.jmxtra
ns.embedded";version="1.0.16",org.jmxtrans.embedded.servlet;uses:="ja
vax.servlet,org.slf4j";version="1.0.16"
Import-Package: com.fasterxml.jackson.core;version="[2.4,3)",com.faste
rxml.jackson.databind;version="[2.4,3)",com.fasterxml.jackson.databin
d.node;version="[2.4,3)",javax.annotation,javax.management,javax.mana
gement.openmbean,javax.servlet;resolution:=optional,org.apache.common
s.io;version="[1.4,2)";resolution:=optional,org.apache.commons.pool2;
version="[2.3,3)";resolution:=optional,org.apache.commons.pool2.impl;
version="[2.3,3)";resolution:=optional,org.python.core;resolution:=op
tional,org.python.modules;resolution:=optional,org.slf4j;version="[1.
7,2)",org.springframework.beans.factory;version="[3.1,4)";resolution:
=optional,org.springframework.beans.factory.annotation;version="[3.1,
4)";resolution:=optional,org.springframework.beans.factory.support;ve
rsion="[3.1,4)";resolution:=optional,org.springframework.beans.factor
y.xml;version="[3.1,4)";resolution:=optional,org.springframework.core
.io;version="[3.1,4)";resolution:=optional,org.springframework.jmx.ex
port.naming;version="[3.1,4)";resolution:=optional,org.springframewor
k.util;version="[3.1,4)";resolution:=optional,org.supercsv.io;version
="[2.1,3)";resolution:=optional,org.supercsv.prefs;version="[2.1,3)";
resolution:=optional,org.w3c.dom
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.6))"
Tool: Bnd-2.4.1.201501161923

@LasneF
Copy link
Contributor Author

LasneF commented May 18, 2015

the pull request make also usage of apache , commons-pool2 optionnal as it is used only in graphite writer. In my context i will not use it so rather not make it as mandatory.

@buildhive
Copy link

jmxtrans project » embedded-jmxtrans #105 SUCCESS
This pull request looks good
(what's this?)

pom.xml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commons-pool2 is also used by GraphiteWriter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done , add a comment on it to be more precise
I currently do not use Graphite ( I use Console Writter or ... a an incomming Custom Outputwriter) so i do not need this dependency

@buildhive
Copy link

jmxtrans project » embedded-jmxtrans #106 SUCCESS
This pull request looks good
(what's this?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require to bump embedded-jmxtrans to 1.1.x as it may cause backward compatibility issues. Anyway, I should already have bumped to 1.1.x when I migrated from commons-pool to commons-pool2.

cyrille-leclerc pushed a commit that referenced this pull request May 18, 2015
Add osgi support. Make common pool optionnal
@cyrille-leclerc cyrille-leclerc merged commit af8a9ed into jmxtrans:master May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants