add support for varying width null terminator for (get/put)ZeroTerminatedByteArray()#112
add support for varying width null terminator for (get/put)ZeroTerminatedByteArray()#112demon36 wants to merge 1 commit intojnr:masterfrom
Conversation
|
Quick comment: Please do PRs using your own branches, rather than using your copies of existing branches. I guess the idea is that existing branches, and especially master, should never have unapproved commits to avoid confusion across forks. |
|
Marking for 2.0 as I think that will be the logical leap forward with the native binary. We will build in fallbacks to old behavior when the binary has not been updated, and build for as many platforms as possible whenever it changes, but we need to be able to move the native bits forward. |
|
anything to be done from my side ? |
|
I was pinged today by @demon36 and would like to revisit this. The problem then, as it is now, is making this change when we do not have access to all native platforms to easily rebuild the jffi stub. If we can do this in an incremental way, falling back on old logic when the binary for a given platform has not been rebuilt, it would mean we can start supporting this feature on at least some platforms. The alternative is to fix the build/platform support problem and get automated builds of as many platforms as possible with other platforms awaiting assistance from the community. |
|
This is still in the pipeline and we are getting closer to having an automated setup to build all these binaries. However, we have been swamped with other work and may not get back to this for a few weeks. |
|
See #124 for ongoing work to tie up the loose ends of the existing qemu native builds. |
related to jnr/jnr-ffi#30