Skip to content

Conversation

@elainabialkowski
Copy link
Contributor

Fixed tests.
Added UserLoggedInEvent alongside PostLoginEvent.
Added UserFirstTimeLoggedInEvent.

This PR is meant to fix #74.

@jo23sh jo23sh self-assigned this Sep 19, 2024
@elainabialkowski
Copy link
Contributor Author

It looks like they moved away from ILogger a few months ago in favour of ILogFactory using Psr\Log\LoggerInterface. That seems to be why the test in master is failing.

@jo23sh
Copy link
Owner

jo23sh commented Sep 21, 2024

@elainabialkowski Many thanks for your contribution which I'll gladly merge!
And absolutely, the logger is an issue of compatibility with NC31 onwards. I have opened #78 for that; it's completely unrelated.

@jo23sh jo23sh merged commit 88873fa into jo23sh:master Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Users created through SSO/SAML authentication aren't recognized as new users

2 participants