Skip to content

Make plugin library compatible with the Unsafe intent detection #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matejdro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make plugin library compatible with the Unsafe intent detection #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion taskerpluginlibrary/src/main/java/com/joaomgcd/taskerpluginlibrary/action/ActionReceivers.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.joaomgcd.taskerpluginlibrary.action
import android.content.BroadcastReceiver
import android.content.Context
import android.content.Intent
import com.joaomgcd.taskerpluginlibrary.TaskerPluginConstants
import com.joaomgcd.taskerpluginlibrary.extensions.canBindFireService
import com.joaomgcd.taskerpluginlibrary.extensions.mayNeedToStartForeground
import com.joaomgcd.taskerpluginlibrary.extensions.runFromTasker
Expand All @@ -14,6 +15,8 @@ class BroadcastReceiverAction : BroadcastReceiver() {
override fun onReceive(context: Context?, intent: Intent?) {
resultCode = TaskerPlugin.Setting.RESULT_CODE_PENDING
try {
intent?.extras?.putBoolean(TaskerPluginConstants.EXTRA_CAN_BIND_FIRE_SETTING, false)

runFromTasker<IntentServiceAction>(context, intent)
} catch (ex: Exception) {
ex.printStackTrace()
Expand All @@ -30,4 +33,4 @@ class IntentServiceAction : IntentServiceParallel("IntentServiceTaskerAction") {
startForegroundIfNeeded(mayNeedToStartForeground)
}
}
}
}
7 changes: 6 additions & 1 deletion taskerpluginlibrary/src/main/java/net/dinglisch/android/tasker/TaskerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,12 @@ public static boolean signalFinish( Context context, Intent originalFireIntent,

if (completionIntentUri != null) {
try {
Intent completionIntent = Intent.parseUri(completionIntentString, Intent.URI_INTENT_SCHEME);
Intent completionIntentSource = Intent.parseUri(completionIntentString, Intent.URI_INTENT_SCHEME);

// Create a new intent with manual copying to comply with the unsafe intent detection
Intent completionIntent = new Intent(completionIntentSource.getAction(), completionIntentSource.getData());
completionIntent.setComponent(completionIntentSource.getComponent());
completionIntentSource.putExtras(completionIntentSource.getExtras());

completionIntent.putExtra(EXTRA_RESULT_CODE, resultCode);

Expand Down