Skip to content

Use as_py_json in place of deprecated as_object_map for Pyodide>=0.29 #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesteve merged 4 commits into from
Nov 8, 2025
+6 −1
Merged

Use as_py_json in place of deprecated as_object_map for Pyodide>=0.29 #201

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7ba5fb
Use `as_py_json` from Pyodide 0.29
agriyakhetarpal Nov 6, 2025
243a55a
Add check on `as_py_json` re: Pyodide version
agriyakhetarpal Nov 6, 2025
14917a4
Lint
agriyakhetarpal Nov 6, 2025
cdd1d67
Oops lint again
agriyakhetarpal Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion threadpoolctl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,7 +1132,12 @@ def _find_libraries_pyodide(self):
)
return

for filepath in LDSO.loadedLibsByName.as_object_map():
if hasattr(LDSO.loadedLibsByName, "as_py_json"): # Pyodide >= 0.29
libs_iter = LDSO.loadedLibsByName.as_py_json()
else:
libs_iter = LDSO.loadedLibsByName.as_object_map() # Pyodide < 0.29

for filepath in libs_iter:
# Some libraries are duplicated by Pyodide and do not exist in the
# filesystem, so we first check for the existence of the file. For
# more details, see
Expand Down
Loading