Skip to content

Bump OpenTelemetry.Exporter packages to 1.15.3 (fixes GHSA-4625-4j76-fww9) and add E2E startup retry loop#172

Merged
jodavis merged 3 commits intofeature/ADR-162-client-side-layout-updatesfrom
copilot/sub-pr-142
May 3, 2026
Merged

Bump OpenTelemetry.Exporter packages to 1.15.3 (fixes GHSA-4625-4j76-fww9) and add E2E startup retry loop#172
jodavis merged 3 commits intofeature/ADR-162-client-side-layout-updatesfrom
copilot/sub-pr-142

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 2, 2026

OpenTelemetry.Exporter.OpenTelemetryProtocol 1.8.1 carries a known moderate vulnerability (GHSA-4625-4j76-fww9 / CVE-2026-42191). Because the build runs with /warnaserror, the NuGet NU1902 audit warning was promoted to a build-breaking error.

Additionally, E2E tests on CI were flakily failing because the Console host occasionally crashes on startup with COMException (0x800700AA): The requested resource is in use. — a transient WebView2 resource conflict when host processes start in rapid succession.

Changes

  • Directory.Packages.props

    • OpenTelemetry.Exporter.OpenTelemetryProtocol: 1.8.11.15.3 (patched version per advisory)
    • OpenTelemetry.Exporter.Console: 1.8.11.15.3 (brought in line with OpenTelemetry.Extensions.Hosting, already at 1.15.3)
  • test/AdaptiveRemote.EndtoEndTests.TestServices/Host/AdaptiveRemoteHost.Builder.cs

    • Added a private HostStartupException class that wraps startup failures and carries the captured process stdout/stderr, enabling the retry logic to inspect what the crash reported.
    • StartWithSettings catch block now throws HostStartupException (wrapping the original) instead of rethrowing, so captured output is always available to callers.
    • Start() now retries up to 3 times when the host crashes with "The requested resource is in use." in its output. Each retry logs a warning and waits a random 1–3 s before the next attempt. All other failure types propagate immediately.

Copilot AI changed the title [WIP] [ADR-162] Working PR for client application support to use backend layout services Bump OpenTelemetry.Exporter packages to 1.15.3 (fixes GHSA-4625-4j76-fww9) May 2, 2026
Copilot finished work on behalf of jodavis May 2, 2026 13:58
Copilot AI requested a review from jodavis May 2, 2026 13:58
@jodavis jodavis marked this pull request as ready for review May 2, 2026 13:58
@jodavis jodavis enabled auto-merge (squash) May 2, 2026 13:59
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

Test Results

540 tests  +540   540 ✅ +540   5m 30s ⏱️ + 5m 30s
  8 suites +  8     0 💤 ±  0 
  8 files   +  8     0 ❌ ±  0 

Results for commit d5468d5. ± Comparison against base commit 2476d59.

♻️ This comment has been updated with latest results.

@jodavis
Copy link
Copy Markdown
Owner

jodavis commented May 2, 2026

@copilot the E2E tests failed, but it's a known issue. Sometimes on CI, the application fails to start because it's being shut down and restarted frequently. This is not a product bug, so I want you to add a retry loop to the test host start up code. If the app host crashes right away on startup, with this specific exception message, just try starting it again. It's more important to run the tests and catch real bugs than it is to straighten out this flaky edge case.

auto-merge was automatically disabled May 2, 2026 23:51

Head branch was pushed to by a user without write access

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 2, 2026

@copilot the E2E tests failed, but it's a known issue. Sometimes on CI, the application fails to start because it's being shut down and restarted frequently. This is not a product bug, so I want you ...

Done in d5468d5. AdaptiveRemoteHost.Builder.Start() now retries up to 3 times when the host crashes on startup with "The requested resource is in use." in its captured output (the COMException 0x800700AA from WebView2). Each retry logs a warning and waits a random 1–3 s before trying again. The retry only triggers for that specific crash — other failures (Inconclusive, process-launch errors, timeout, etc.) propagate immediately as before.

Copilot AI changed the title Bump OpenTelemetry.Exporter packages to 1.15.3 (fixes GHSA-4625-4j76-fww9) Bump OpenTelemetry.Exporter packages to 1.15.3 (fixes GHSA-4625-4j76-fww9) and add E2E startup retry loop May 2, 2026
Copilot finished work on behalf of jodavis May 2, 2026 23:51
Copilot AI requested a review from jodavis May 2, 2026 23:51
@jodavis jodavis merged commit 2a1c6e7 into feature/ADR-162-client-side-layout-updates May 3, 2026
3 checks passed
@jodavis jodavis deleted the copilot/sub-pr-142 branch May 3, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants