Bump OpenTelemetry.Exporter packages to 1.15.3 (fixes GHSA-4625-4j76-fww9) and add E2E startup retry loop#172
Conversation
…6-fww9 Agent-Logs-Url: https://github.com/jodavis/AdaptiveRemote/sessions/2a25fc1c-dd69-4762-a4d7-4c87cf614e29 Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>
|
@copilot the E2E tests failed, but it's a known issue. Sometimes on CI, the application fails to start because it's being shut down and restarted frequently. This is not a product bug, so I want you to add a retry loop to the test host start up code. If the app host crashes right away on startup, with this specific exception message, just try starting it again. It's more important to run the tests and catch real bugs than it is to straighten out this flaky edge case. |
Agent-Logs-Url: https://github.com/jodavis/AdaptiveRemote/sessions/7c9c8221-a900-4e4d-8207-7eb2718f58c6 Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>
Head branch was pushed to by a user without write access
Done in d5468d5. |
2a1c6e7
into
feature/ADR-162-client-side-layout-updates
OpenTelemetry.Exporter.OpenTelemetryProtocol1.8.1 carries a known moderate vulnerability (GHSA-4625-4j76-fww9 / CVE-2026-42191). Because the build runs with/warnaserror, the NuGetNU1902audit warning was promoted to a build-breaking error.Additionally, E2E tests on CI were flakily failing because the Console host occasionally crashes on startup with
COMException (0x800700AA): The requested resource is in use.— a transient WebView2 resource conflict when host processes start in rapid succession.Changes
Directory.Packages.propsOpenTelemetry.Exporter.OpenTelemetryProtocol:1.8.1→1.15.3(patched version per advisory)OpenTelemetry.Exporter.Console:1.8.1→1.15.3(brought in line withOpenTelemetry.Extensions.Hosting, already at1.15.3)test/AdaptiveRemote.EndtoEndTests.TestServices/Host/AdaptiveRemoteHost.Builder.csHostStartupExceptionclass that wraps startup failures and carries the captured process stdout/stderr, enabling the retry logic to inspect what the crash reported.StartWithSettingscatch block now throwsHostStartupException(wrapping the original) instead of rethrowing, so captured output is always available to callers.Start()now retries up to 3 times when the host crashes with"The requested resource is in use."in its output. Each retry logs a warning and waits a random 1–3 s before the next attempt. All other failure types propagate immediately.