fix(git): refactor untracked file handling in getAllFileDiffs function#84
Merged
johannesjo merged 1 commit intojohannesjo:mainfrom Apr 24, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Thank you very much ! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes untracked files not appearing in the diff viewer when multiple untracked files reside under a newly created
directory.
getAllFileDiffspreviously usedgit status --porcelainto discover untracked files. When an entire directoryis untracked, Git collapses the output to a single directory entry (e.g.
?? src/components/) instead of listingeach individual file. The code treated this directory path as a file path,
stat.isFile()returnedfalse, andevery untracked file inside that directory was silently skipped — so they never appeared in the diff preview.
This change replaces
git status --porcelainwithgit ls-files --others --exclude-standard, which always emitsone line per file regardless of directory structure. This aligns
getAllFileDiffswithgetChangedFiles, whichalready uses the same
ls-filescommand for untracked file detection.Issues Resolved
src/components/mdx/Blockquote.tsx) are now correctly included in thediff viewer output.
getChangedFiles) showed the files, butclicking them opened an empty diff because
getAllFileDiffshad dropped them.