Skip to content

Conversation

@mgalardini
Copy link

Relatively ugly hack to allow downstream packages to use the library

I could not get f2py (numpy external modules builder) to work with glmnet_python, so I resorted to this hack, which is slightly more elegant than this other fork.

Relatively ugly hack to allow downstream packages to use the library
@johnlees
Copy link
Owner

That looks sensible!
Do we also want to add an ext_modules section (like this example: https://github.com/johnlees/unitig-caller/blob/master/setup.py)

@mgalardini
Copy link
Author

Oh nice! Didn't notice that, looks much cleaner, I'll port it over and update the PR, thanks!

@mgalardini
Copy link
Author

Seems to be working fine now, thanks again

@johnlees johnlees merged commit 6f0ce0b into johnlees:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants