Remove await qualifier from tmpPath example#1
Open
ryanbaer wants to merge 1 commit intojohnlindquist:mainfrom
Open
Remove await qualifier from tmpPath example#1ryanbaer wants to merge 1 commit intojohnlindquist:mainfrom
await qualifier from tmpPath example#1ryanbaer wants to merge 1 commit intojohnlindquist:mainfrom
Conversation
The rest of the examples in these docs for `tmpPath` indicate that it does not return a Promise. Additionally, the function itself also currently does not return a Promise. If there are some changes planned here to make this async, feel free to disregard this PR. Otherwise, this is just some tidying up to remove the `await` and reduce any future confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rest of the examples in these docs for
tmpPathindicate that it does not return a Promise. Additionally, the function itself also currently does not return a Promise.If there are some changes planned here to make this async, feel free to disregard this PR.
Otherwise, this is just some tidying up to remove the
awaitand reduce any future confusion.