-
Notifications
You must be signed in to change notification settings - Fork 13
fix: glab output parameter #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There is no -o parameter in newest version of glab. Fixed it by using the correct output param: -F --output Format output as: text, json. (text)
📝 WalkthroughWalkthroughA flag in the GitLab MR view command was updated from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)src/commands/*.ts📄 CodeRabbit inference engine (.cursor/rules/project.mdc)
Files:
🧬 Code graph analysis (1)src/commands/pr.ts (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/commands/pr.ts (1)
157-168: The-F jsonflag is correct for glab 1.80.4, but add error handling for the execa call and colored console feedback.Confirmed:
glab mr viewin version 1.80.4 uses-F --outputfor format specification, so-F jsonis correct.However, the code lacks error handling for the
execa()call itself—it only catches JSON parse errors. The glab command could fail (e.g., not found, invalid credentials, network error). Add a try-catch around the execa call or handle the potential error. Additionally, per the coding guidelines forsrc/commands/*.tsfiles, provide colored console feedback for error messages to enhance the CLI experience.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/commands/pr.ts
🧰 Additional context used
📓 Path-based instructions (1)
src/commands/*.ts
📄 CodeRabbit inference engine (.cursor/rules/project.mdc)
src/commands/*.ts: Leverage Execa to execute Git commands and other external processes.
Provide clear, colored console feedback for success and error messages in CLI commands.
Files:
src/commands/pr.ts
🧬 Code graph analysis (1)
src/commands/pr.ts (1)
build/commands/pr.js (3)
execa(16-16)execa(112-116)execa(124-124)
There is no -o parameter in newest version of glab. Fixed it by using the correct output param:
-F --output Format output as: text, json. (text)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.