Themes for BeepBox #131
Open
Themes for BeepBox #131
+660
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to redesign the theme prompt to allow you to preview themes, I also made it so then the prompt is more unique. Although this design isn't new, It's something I created myself for a different mod, I decided that would work here better than what JummBox does. Feel free to change this however you feel like if you decide to use this for BeepBox.
This is what the prompt looks like:
The main color of the theme is shown as an example of what the theme is going to look like. Plus the names of the themes do a really good job explaining what the theme looks like by literally being the name of the color. I decided to name them after gems specifically because it sounds cool, and people can easily associate the name of a gem to a color.
I'm sure you already know what the already existing themes look like, so here's a collection of all of the themes that are new in this pull request:
BeepBox Competitive - Although not new, this theme has never been in main BeepBox so it makes sense for it to be here.
Marine
Ruby - This theme used to be named "Flame" though I renamed it to match the other themes.
Amber
Emerald
Amethyst
Another change I made I'll bring up real quick is that the song player now displays what theme you are using. I'm not sure why this wasn't a thing before, but now there are 4 times the number of themes I think that it's somewhat needed now.
