Fix octave scrollbar desync. Issue #123 #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123
With both Show Octave Scrollbar and Show All Channels turned on, the secondary channels should scroll according to the current scrollbar position, not their stored position.
The previous behavior had one benefit, which is that I could scroll the octave bar to a position, and then switch to another channel to use it as a visual reference. However, you can still do this and select + move the notes down if that's a need. What's far more important is, there was no good way to add chords between channels because you couldn't trust the pitch shown and now you can. It's also far less surprising user behavior to have all notes scroll. I believe this should fully replace the previous behavior.
Video.mp4