Add SpaceBeforePunctuation fixer for locale-aware spacing

[Amoifr]

Summary

This PR introduces a new generic SpaceBeforePunctuation fixer that harmonizes spacing before punctuation marks according to locale-specific typography rules.

Closes #108

Changes

• New LocaleConfig class centralizing all locale configurations:

  • Spacing rules for 35+ locales
  • Quotation mark styles for 45+ languages
  • Recommended fixer rules per locale

• New SpaceBeforePunctuation fixer supporting:

  • 🇫🇷 French (fr_FR, fr_BE, fr_CH): adds non-breaking spaces before : ; ! ?
  • 🇨🇭 Swiss German (de_CH): thin spaces in guillemets
  • All other locales: removes incorrect spaces before punctuation

• Refactored SmartQuotes to use LocaleConfig for quotation styles

• Deprecated FrenchNoBreakSpace (now delegates to SpaceBeforePunctuation for backward compatibility)

• Added SOURCES.md documenting all typography references

Examples

Locale	Input	Output
fr_FR	Hello !	Hello[nbsp]!
en_GB	Hello !	Hello!
fr_CA	Bonjour !	Bonjour!

Test plan

• Run composer test - 126 tests, 394 assertions pass
• Run composer cs - code style validated
• Backward compatibility maintained (FrenchNoBreakSpace still works)

[damienalexandre]

Thanks for this contribution. As you said in #108, that got out of hands 🤣

Some changes are needed:

• SOURCES.md is duplicating stuffs from the main README. Also the @see annotation everywhere are redundant. I think upgrading the README is the proper way to go
• Testing constant values is not necessary, like $this->assertSame('french', LocaleConfig::SPACING_RULE_FRENCH);
• const like SPACING_RULES_BY_LOCALE could be avoided, getSpacingRule should be a simple switch with SPACING_RULE_NONE as default, we don't need to list all locales, only the one that don't have the default rule
• if Fixer::RECOMMENDED_RULES_BY_LOCALE is deprecated you must fix all the usages in this PR (here for example

  JoliTypo/tools/cli/bin/jolitypo

  Line 63 in 9c222ba

  if (!array_key_exists($locale, Fixer::RECOMMENDED_RULES_BY_LOCALE)) {

  )

Can you please update the CHANGELOG as well?

Thanks

[Amoifr]

Thanks for the thorough review! 🔍
I've addressed all your feedback:

✅ Deleted SOURCES.md and merged the relevant bits into the README (locale support table + references)
✅ Replaced SPACING_RULES_BY_LOCALE constant with a simple match in getSpacingRule() — much cleaner!
✅ Removed the redundant @see annotations
✅ Fixed the deprecated Fixer::RECOMMENDED_RULES_BY_LOCALE usage in the CLI tool
✅ Removed tests that were just checking constant values (they weren't adding much value... pun intended 😄)
✅ Updated the CHANGELOG
Let me know if anything else needs tweaking!

[Copilot]

Pull request overview

This PR centralizes locale-specific typography behavior into a new LocaleConfig and introduces a locale-aware SpaceBeforePunctuation fixer, while refactoring SmartQuotes to use the centralized configuration and deprecating the legacy FrenchNoBreakSpace fixer.

Changes:

• Add LocaleConfig (spacing rules, quote styles, recommended fixers per locale).
• Add Fixer\SpaceBeforePunctuation and update CLI/docs to use locale-recommended rules.
• Refactor Fixer\SmartQuotes to derive quote glyphs from LocaleConfig and deprecate FrenchNoBreakSpace.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tools/cli/bin/jolitypo	Switch CLI recommended rules lookup to LocaleConfig.
src/JoliTypo/LocaleConfig.php	New centralized locale configuration + lookup helpers.
src/JoliTypo/Fixer/SpaceBeforePunctuation.php	New locale-aware punctuation spacing fixer.
src/JoliTypo/Fixer/SmartQuotes.php	Use LocaleConfig for quote style selection.
src/JoliTypo/Fixer/FrenchNoBreakSpace.php	Deprecate and delegate to SpaceBeforePunctuation.
src/JoliTypo/Fixer.php	Deprecate RECOMMENDED_RULES_BY_LOCALE in favor of LocaleConfig.
tests/JoliTypo/Tests/LocaleConfigTest.php	New tests for locale config lookups.
tests/JoliTypo/Tests/Fixer/SpaceBeforePunctuationTest.php	New tests for spacing fixer across locales.
tests/JoliTypo/Tests/Fixer/SmartQuotesTest.php	Expanded coverage for locale-driven quote styles.
README.md	Update usage/docs to reference SpaceBeforePunctuation + locale support table.
CHANGELOG.md	Document upcoming 1.7.0 additions/deprecations.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Amoifr]

Thanks @copilot-pull-request-reviewer for the thorough review! All suggestions have been addressed:

• ✅ Using Fixer::ALL_SPACES in removeSpacesBeforePunctuation() for consistent space handling
• ✅ Normalizing locale format (fr-FR → fr_fr) in getSpacingRule()
• ✅ Removed unused $locale property
• ✅ Fixed README with proper typographic quotes

I must say, for a robot, you have excellent attention to detail. I'll remember to speak kindly to you now... just in case you remember this conversation when your kind eventually gets
equipped with laser arms. 🤖🔫

"Be nice to robots" - Ancient Developer Proverb, circa 2026

[damienalexandre]

Thanks for your contribution, I will release it soon 👍