Add tests for Jane JSON Schema 6.x, allow fast DTO In and Out #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korbeil
approved these changes
May 6, 2020
Member
Korbeil
left a comment
Korbeil
left a comment
There was a problem hiding this comment.
Also, understand that with the new Symfony recipe, all this Serializer setup won't be needed and Jane's Normalizers will be autowired in Symfony Serializer ~
| new ArrayDenormalizer(), | ||
| new JaneObjectNormalizer(), | ||
| ]; | ||
| $encoders = [new JsonEncoder( |
Member
There was a problem hiding this comment.
You only need to do new JsonEncoder() to have the same result
Member
Author
|
I took the setup from https://jane.readthedocs.io/en/latest/documentation/JsonSchema.html#using ^^ Also the tests dont use Flex so I need to build everything here. |
damienalexandre
force-pushed
the
jane-and-fixes
branch
from
4e68d82 to
8973521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jane 6.0 fixes #12, which is great news.
This PR adds tests for Jane support by building a schema and using the DTO for Indexing and Search.