Prevent the friend rule from allowing an actor to be their own friend #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonase
added a commit
that referenced
this pull request
Jan 6, 2014
Prevent the friend rule from allowing an actor to be their own friend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands now the
friendsrule is returning the actor themselves as a friend, since I believe they can satisfy both p1 and p2. I added a clause that p1 != p2, I think that's all that's necessary to fix it. I also changed the default person to Sigourney Weaver so the mistake would be checked for when running the query.Seems like this bug could also exist if there were some Woody Allen movies in your database (actor and director), but doesn't seem to exist so I'm not gonna worry about that one 😄
Awesome use of edn for this, super easy to understand.