Skip to content

Conversation

@jonasoreland
Copy link
Owner

  1. Remove usage of NodeApi,
    it mostly works without it. And for the scenario
    where the phone and the watch looses connection,
    probably a human will intervene anyway.

  2. Fix the intents so that one can use the buttons on the watch. note: not everything seems to be working (yet)

  3. Fix build things
    a) it seems like gms for wearable is split from main gms? b) fix wear debug version applicationSuffix
    c) fix build without mapbox.properties

TESTED=Manually tested that the wear apps seems to mostly function in debug build

1) Remove usage of NodeApi,
it mostly works without it. And for the scenario
where the phone and the watch looses connection,
probably a human will intervene anyway.

2) Fix the intents so that one can use the buttons on the watch.
note: not everything seems to be working (yet)

3) Fix build things
a) it seems like gms for wearable is split from main gms?
b) fix wear debug version applicationSuffix
c) fix build without mapbox.properties

TESTED=Manually tested that the wear apps seems to mostly function in debug build
@jonasoreland jonasoreland requested a review from gerhardol May 15, 2025 19:56
Copy link
Collaborator

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not run, but I do not see this affecting use without Wear.

@jonasoreland
Copy link
Owner Author

please take another look ?

@gerhardol
Copy link
Collaborator

Updated dependencies in #1214, fixed a few lints too.
The following should probably be addressed, but that is a little more job.
What Android API on the WearOS device have you been testing with?

Will not be able to test much, just spinning up on a Pixal 8 w Android 15.

--

Lint found errors in the project; aborting build.

Fix the issues identified by lint, or add the issues to the lint baseline via gradlew updateLintBaseline.
For more details, see https://developer.android.com/studio/write/lint#snapshot

C:\dev\gc\runnerup\wear\src\main\java\org\runnerup\service\ListenerService.java:136: Error: When targeting Android 13 or higher, posting a permission requires holding the POST_NOTIFICATIONS permission [NotificationPermission]
        notificationManagerCompat.notify(notificationId, notification);
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "NotificationPermission":
   When targeting Android 13 and higher, posting permissions requires holding
   the runtime permission android.permission.POST_NOTIFICATIONS.

1 errors, 0 warnings

@jonasoreland
Copy link
Owner Author

Hi again,

  1. I have a 2.45 WearOS Watch
    is that new or old ??

  2. I'm not sure what you want me to do...
    a) should I merge my patch first,
    b) should your patch be merged first ?
    c) should I fix the lint problem and then ask for new review ?

Thanks!
/Jonas

@gerhardol
Copy link
Collaborator

Hi again,

1. I have a 2.45 WearOS Watch
   is that new or old ??

2. I'm not sure what you want me to do...
   a) should I merge my patch first,
   b) should your patch be merged first ?
   c) should I fix the lint problem and then ask for new review ?

WearOS uses a certain Android API.
https://developer.android.com/training/wearables/versions/3/update
WearOS 2 seem to be Android 9, WearOS3 11
WearOS 4 is Android 13, the notifications will likely fail then (not sure what the effect is)

Nothing works before this PR, but this may fail newer watches

@jonasoreland
Copy link
Owner Author

Fixed the lint problem and some minor tweaks.

Please take another look ?

Copy link
Collaborator

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only brief use in phone app, but do not see this to be affecting the normal functionality.

@jonasoreland
Copy link
Owner Author

Thanks!

@jonasoreland jonasoreland merged commit 921b86b into master May 19, 2025
@jonasoreland jonasoreland deleted the wear0 branch May 29, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants