Test harder that "provides" is sane

[jonathanstowe]

<lucasb> "HTTP::Parser::XML" : "lib/HTML/Parser/XML.pm6"  # <-- HTML::Parser::XML's META.info 'provides' section

Easiest way is to attempt to require the file and see if the symbol is defined.

[zoffixznet]

Not sure how best to address this, but the META test is passing, despite a whole ton of files missing from provides section:

zoffix@leliana:/tmp/tmp.rFCTh1cfsy$ tree lib
lib
└── lib/RT
    └── lib/RT/REST
        ├── lib/RT/REST/Client
        │   ├── lib/RT/REST/Client/Grammar
        │   │   └── lib/RT/REST/Client/Grammar/Actions.pm6
        │   └── lib/RT/REST/Client/Grammar.pm6
        └── lib/RT/REST/Client.pm6

4 directories, 3 files
You have new mail in /var/mail/zoffix
zoffix@leliana:/tmp/tmp.rFCTh1cfsy$ cat META6.json 
{
    "perl"         : "6.c",
    "name"         : "RT::REST::Client",
    "version"      : "1.001002",
    "description"  : "Use Request Tracker's (RT) REST client interface",
    "depends"      : [
        "IO::Socket::SSL",
        "HTTP::UserAgent",
        "URI",
        "URI::Escape"
    ],
    "test-depends" : [ "Test", "Test::META" ],
    "provides"     : {
        "RT::REST::Client" : "lib/RT/REST/Client.pm6"
    },
    "authors"      : [ "Zoffix Znet" ],
    "support"      : {"source"   : "git://github.com/zoffixznet/perl6-RT-REST-Client.git"}
}
zoffix@leliana:/tmp/tmp.rFCTh1cfsy$ prove6 t/meta.t 
t/meta.t .. 
    ok 1 - have a META file
    ok 2 - META parses okay
    ok 3 - have all required entries
    ok 4 - 'provides' looks sane
    ok 5 - Optional 'authors' and not 'author'
    ok 6 - name has a hypen rather than '::' (if this is intentional please pass :relaxed-name to meta-ok)
    ok 7 - no 'v' in version strings (meta6 version greater than 0)
    1..7
ok 1 - Project META file is good
1..1
ok
All tests successful.
Files=1, Tests=1,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.28 cusr  0.06 csys =  0.37 CPU)
Result: PASS
zoffix@leliana:/tmp/tmp.rFCTh1cfsy$ 

[jonathanstowe]

Yeah, it's either an optional test, a warning, or there should be an ignore files option as there may be a perfectly valid reason for not wanting to install a file that is in lib (provided for a test for instance.)

I'll have a think.

[jonathanstowe]

This seems to have reared its head in the recent squashathon. Should at least warn if there are files present in the lib directory that aren't in provides