Meson: Add support for Meson build system by kakurasan · Pull Request #675 · jonls/redshift

kakurasan · 2018-10-08T13:54:54Z

The changes in this PR add support for Meson build system.

Benefits

Build time will be reduced
No need to run bootstrap script
intltool is not needed, instead, recent gettext tools (msgfmt and xgettext) can handle *.appdata.xml.in and *.desktop.in files

Dependencies

Python 3.5 or later
gettext 0.19.7 or later
Meson 0.47.0 or later
Ninja 1.5 or later

How to build / install with Meson

(Configure)
$ meson ([options...]) [builddir]

(Reconfigure or show config)
$ meson configure ([options...]) [builddir]

(Build)
$ ninja -C [builddir]

(Install)
$ sudo ninja -C [builddir] install
or
$ DESTDIR=/path/to/destdir ninja -C [builddir] install

Project options

Name	Value	Description
nls	auto,enabled,disabled	NLS support
drm	auto,enabled,disabled	DRM method
randr	auto,enabled,disabled	RANDR method
vidmode	auto,enabled,disabled	VidMode method
quartz	auto,enabled,disabled	Quartz (macOS) method
wingdi	auto,enabled,disabled	WinGDI method
corelocation	auto,enabled,disabled	CoreLocation (macOS) provider
geoclue2	auto,enabled,disabled	Geoclue2 provider
gui	auto,enabled,disabled	GUI status icon
ubuntu	auto,enabled,disabled	Ubuntu icons
apparmor	auto,enabled,disabled	AppArmor profile
systemduserunitdir	Path to directory,auto,disabled	Directory for systemd user unit files

How to update .pot file and .po files

Update redshift.pot:

$ ninja -C [builddir] redshift-pot

Update redshift.pot and *.po:

$ ninja -C [builddir] redshift-update-po

How to create dist (source .tar.xz) file in git tree

$ ninja -C [builddir] dist

[builddir]/meson-dist/redshift-[version].tar.xz will be created.

Issues and notes

A new translatable string redshift comes from Icon=redshift in data/applications/*.desktop.in files: Icon= is actually translatable, see https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys
Some existing *.in files (appdata, desktop) are not compatible with "Meson + gettext"
- We can extract translatable strings and merge translations with "Meson + gettext 0.19.7 or later", however, the expected file formats (appdata XML and Desktop template) are different from existing files (for intltool).
- Some meson_*.in files that match the expected formats were added. They are not compatible with intltool.
- We can replace existing *.in files (for intltool) with the added files when dropping autotools-based build system in the future.
Travis CI
- Python, Ninja, and gettext are too old on Ubuntu Trusty.
  - We use Ubuntu Xenial to use newer gettext and Ninja
  - Python 3.7 is available without additional installation (as of Feb 2019): We use it (~/virtualenv/python3.7/bin/) directly.
AppVeyor
- We download Ninja for Windows from https://github.com/mesonbuild/cidata repo that is maintained by Meson developer.
- Meson can detect/use Microsoft compilers on Windows if calling vcvarsall.bat beforehand, but there are lots of MSVC-specific issues.
Unity build (meson --unity=on) failure
- Both hooks.c and redshift.c have static variable period_names. It causes compilation error (error: redefinition of ‘period_names’).
Issues in Meson 0.48.0
- Travis Ubuntu build fails: ~~Fixed upstream, no release yet.~~ Fixed in 0.48.1.
- Target name related warnings: ~~Fixed upstream, no release yet.~~ Fixed in 0.49.0.
- We can pin Meson version if pip3 is used (e.g. pip3 install meson==0.47.2).
- We use Meson 0.49.2 (pip3 install meson==0.49.2).

jonls · 2018-10-20T21:10:59Z

@kakurasan Thanks for doing this! I was looking into meson earlier this year but I ran into a number of issues. My initial question looking at this is about keeping both the autotools build system and meson (it looks like you're keeping both and testing both on Travis and Appveyor). I think I'd want to completely replace autotools before adding meson. Maintaining two separate build systems in Redshift is going to be too much work. Would that be feasible at this point and is there anything stopping you from completely replacing autotools?

kakurasan · 2018-10-21T07:43:02Z

Hello.

My initial question looking at this is about keeping both the autotools build system and meson (it looks like you're keeping both and testing both on Travis and Appveyor).

Some projects that have Meson support still support autotools (See the list in https://mesonbuild.com/Users.html, in some projects Meson is "not the default yet"). I guess they are in a period of transition (e.g. for testing).

I think I'd want to completely replace autotools before adding meson. Maintaining two separate build systems in Redshift is going to be too much work. Would that be feasible at this point and is there anything stopping you from completely replacing autotools?

Nothing else. It would be simpler and easy to maintain if dropping autotools. Redshift's tree is simple and already tested with Meson, so I think we can now replace unless we need transition period.

valpackett · 2019-02-24T13:30:32Z

src/meson.build

+redshift_libs += libredshift_common
+
+executable('redshift',
+  redshift_sources,


dependencies : redshift_deps should be used here (in the executable) too, in order to avoid losing dependencies' include directories.

This doesn't affect anything as-is, but with #704 (Wayland support) on FreeBSD it would lose /usr/local/include from the include path and there's an error about not finding wayland-client.h when building redshift.c.

@myfreeweb You're right, I didn't test on FreeBSD but confirmed cflags for external libs were missing when compiling redshift.c (potential build issue) and dependencies : redshift_deps fixed it.
Thanks for your feedback!

CameronNemo · 2019-03-16T06:56:55Z

What functionality does this offer that wasn't previously available?

kakurasan · 2019-03-16T13:35:47Z

This PR doesn't add any functionalities to redshift itself. It only changes the build system for redshift.

Meson doesn't need intltool and instead relies on recent version of gettext. Some existing files for intltool (*.appdata.xml.in and *.desktop.in) are incompatible with gettext and we need another set of them.

Meson 0.49.0 is already tested.

Supported since 0.49. Required Meson version is unchanged.

…eyor.yml" This reverts commit 376fca1.

Supported since 0.53.0.

CameronNemo · 2020-10-25T22:38:51Z

meson.build

+# Check Geoclue2 location provider
+gio_dep = dependency(
+  'gio-2.0', version : '>= 2.26', required : get_option('geoclue2'))
+if gio_dep.found()


if the geoclue2 option is disabled, but the gio dependency is found, what happens? same for similar checks in this file.

When -Dgeoclue2=disabled is specified, Geoclue2 support will be disabled and GIO will not be used (GIO is used only in Geoclue2 location provider).

The value of the geoclue2 option (type : feature) is auto in meson_options.txt: Geoclue2 support will be enabled only when GIO is detected

If -Dgeoclue2=enabled is specified and GIO is not found, an error will occur (build failure)

jonls self-requested a review October 8, 2018 17:17

kakurasan force-pushed the add_meson_support branch 2 times, most recently from 8e08701 to 7addcb4 Compare October 22, 2018 14:28

valpackett reviewed Feb 24, 2019

View reviewed changes

minus7 mentioned this pull request Aug 23, 2019

Wayland support (wlr_gamma_control_unstable_v1) #663

Closed

kakurasan added 14 commits June 14, 2020 13:29

Meson: Add support for Meson build system

368de52

Meson doesn't need intltool and instead relies on recent version of gettext. Some existing files for intltool (*.appdata.xml.in and *.desktop.in) are incompatible with gettext and we need another set of them.

Meson: Replace autotools-based build system

944decc

Meson: Fix RPM build errors (redshift.spec)

92a6e77

Meson: Use version 0.49.0

57d579c

Meson 0.49.0 is already tested.

Meson: Fix potential build issue when compiling "redshift.c"

bb98257

Meson: Get rid of intltool-related files from .gitignore

6b2fa5b

Meson: Use Ubuntu Xenial in .travis.yml

a606714

Meson: Use Meson 0.49.2

2e4d0d2

Meson: Don't add unused PATH ~/.local/bin in .travis.yml

af9561c

Meson: We don't need to use sudo in .travis.yml

cc3860b

Meson: Use "/" instead of join_paths()

b03b3b6

Supported since 0.49. Required Meson version is unchanged.

Travis: Remove "brew upgrade python"

12943e8

Meson: Set PATH to use gettext on macOS in .travis.yml

3ea6d08

Meson: Use Meson 0.54.2

7b78aa1

kakurasan force-pushed the add_meson_support branch from fe1f046 to 7b78aa1 Compare June 14, 2020 05:42

kakurasan added 5 commits June 14, 2020 15:05

Meson: Install Ninja from PyPI in .travis.yml

4a8fbf3

Meson: Change Meson version and install ninja via pip in appveyor.yml

376fca1

Revert "Meson: Change Meson version and install ninja via pip in appv…

a2efc3d

…eyor.yml" This reverts commit 376fca1.

Meson: Use Meson 0.54.2 in appveyor.yml

d4e7ade

Meson: Use summary() instead of message()

7e6d22e

Supported since 0.53.0.

CameronNemo reviewed Oct 25, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Meson: Add support for Meson build system#675

Meson: Add support for Meson build system#675
kakurasan wants to merge 19 commits intojonls:masterfrom
kakurasan:add_meson_support

kakurasan commented Oct 8, 2018 •

edited

Loading

Uh oh!

jonls commented Oct 20, 2018

Uh oh!

kakurasan commented Oct 21, 2018

Uh oh!

valpackett Feb 24, 2019

Uh oh!

kakurasan Feb 25, 2019

Uh oh!

CameronNemo commented Mar 16, 2019

Uh oh!

kakurasan commented Mar 16, 2019

Uh oh!

CameronNemo Oct 25, 2020

Uh oh!

kakurasan Oct 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kakurasan commented Oct 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benefits

Dependencies

How to build / install with Meson

Project options

How to update .pot file and .po files

How to create dist (source .tar.xz) file in git tree

Issues and notes

Uh oh!

jonls commented Oct 20, 2018

Uh oh!

kakurasan commented Oct 21, 2018

Uh oh!

valpackett Feb 24, 2019

Choose a reason for hiding this comment

Uh oh!

kakurasan Feb 25, 2019

Choose a reason for hiding this comment

Uh oh!

CameronNemo commented Mar 16, 2019

Uh oh!

kakurasan commented Mar 16, 2019

Uh oh!

CameronNemo Oct 25, 2020

Choose a reason for hiding this comment

Uh oh!

kakurasan Oct 26, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kakurasan commented Oct 8, 2018 •

edited

Loading