fixed crash on iOS12 and added dismiss handler #21
Closed
luka-w wants to merge 7 commits intojoomcode:mainfrom
Closed
fixed crash on iOS12 and added dismiss handler #21luka-w wants to merge 7 commits intojoomcode:mainfrom
luka-w wants to merge 7 commits intojoomcode:mainfrom
Conversation
Add dissmisCompletion to presentBottomSheet
mikhailmaslo
requested changes
Jul 13, 2023
| present(viewController, animated: true, completion: nil) | ||
| } | ||
|
|
||
| func presentBottomSheet(viewController: UIViewController, configuration: BottomSheetConfiguration, dissmisCompletion: @escaping (() -> Void)) { |
Collaborator
There was a problem hiding this comment.
Can we make this option optional and nil by default and delete function above presentBottomSheet(viewController:configuration:)? Then, we would have much less copy-paste
Collaborator
There was a problem hiding this comment.
Also, can you please fix a typo?
Suggested change
| func presentBottomSheet(viewController: UIViewController, configuration: BottomSheetConfiguration, dissmisCompletion: @escaping (() -> Void)) { | |
| func presentBottomSheet(viewController: UIViewController, configuration: BottomSheetConfiguration, dismissCompletion: @escaping (() -> Void)) { |
Comment on lines
+58
to
+60
| dismissCompletion: { | ||
| print("TWA: dismissCompletion") | ||
| } |
Collaborator
There was a problem hiding this comment.
If this option is not needed let's just ignore it and remove dismissCompletion?
mikhailmaslo
requested changes
Jul 13, 2023
| present(viewController, animated: true, completion: nil) | ||
| } | ||
|
|
||
| func presentBottomSheet(viewController: UIViewController, configuration: BottomSheetConfiguration, dissmisCompletion: @escaping (() -> Void)) { |
Collaborator
There was a problem hiding this comment.
Also, can you please fix a typo?
Suggested change
| func presentBottomSheet(viewController: UIViewController, configuration: BottomSheetConfiguration, dissmisCompletion: @escaping (() -> Void)) { | |
| func presentBottomSheet(viewController: UIViewController, configuration: BottomSheetConfiguration, dismissCompletion: @escaping (() -> Void)) { |
This was referenced Jul 13, 2023
Collaborator
|
I've implemented your proposal in release 2.0.3, so I'm closing this PR Thank you for contribution 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crash on iOS 12 by providing missing initializer in navigation controller - #18
Additionally, provide dismiss handler