Skip to content

Fix issue with SwiftUI View hosted in a UIHostingController #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikhailmaslo merged 2 commits into from
Sep 29, 2022
Merged

Fix issue with SwiftUI View hosted in a UIHostingController #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f54f04a
Fix issue with SwiftUI View hosted in a UIHostingController
rusik Aug 10, 2022
5831743
Improve fix for interactive dismiss cancellation bug
rusik Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Sources/BottomSheet/Core/Presentation/BottomSheetPresentationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,12 @@ extension BottomSheetPresentationController: UIViewControllerAnimatedTransitioni

let completion = { (completed: Bool) in
transitionContext.completeTransition(completed && !transitionContext.transitionWasCancelled)
// For fix bug: https://openradar.appspot.com/FB9075949
if #available(iOS 13, *), transitionContext.transitionWasCancelled {
let sourceViewFrame = sourceView.frame
sourceView.frame = .zero
sourceView.frame = sourceViewFrame
}
}

let options: UIView.AnimationOptions = transitionContext.isInteractive ? .curveLinear : .curveEaseInOut
Expand Down