[2.x] PR 281 follow up - cast boolean option and fix code style#333
Merged
Hackwar merged 3 commits intojoomla-framework:2.0-devfrom Mar 30, 2025
Merged
Conversation
This was referenced Mar 22, 2025
Merged
richard67
changed the title
HLeithner
approved these changes
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #281 (comment)
Summary of Changes
This pull request (PR) adds a type cast to bool to the code added with PR #281 in the constructor so that the new boolean parameter behaves like the already existing parameter
$options['select'].In addition it fixes code style of the parts changed by PR #281 , and it changes the order of the
$configarray in theconnectmethod so it fits to the 3.x-dev branch PR #332 for merging up the change from PR #281 .Testing Instructions
Code review.
Documentation Changes Required
None.