Chore - Require positive tests on PHP 8.0, additionally test PHP 8.1#39
Merged
nibra merged 6 commits intojoomla-framework:2.0-devfrom Sep 23, 2021
nibra:php8
Merged
Chore - Require positive tests on PHP 8.0, additionally test PHP 8.1#39nibra merged 6 commits intojoomla-framework:2.0-devfrom nibra:php8
nibra merged 6 commits intojoomla-framework:2.0-devfrom
nibra:php8
Conversation
Tests are relying on implementation details of the library
8 tasks
|
I may be testing in a different way from you guys, but using PHPCompatibility tests on tag 2.0.0 fails even for PHP 7.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Drone configuration
Testing Instructions
None
Documentation Changes Required
None