Skip to content

[5.4] add unit tests for form rules#46723

Merged
muhme merged 7 commits intojoomla:5.4-devfrom
heelc29:5.4/unittest/formfules
Feb 4, 2026
Merged

[5.4] add unit tests for form rules#46723
muhme merged 7 commits intojoomla:5.4-devfrom
heelc29:5.4/unittest/formfules

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Jan 20, 2026

Summary of Changes

add unit test fore some form rules
also covers updated OptionsRule (#46608)

Testing Instructions

phpunit

Expected result AFTER applying this Pull Request

more tests

heelc29 and others added 2 commits January 20, 2026 12:14
@richard67
Copy link
Member

I have tested this item ✅ successfully on 8ae628e

Tested by review:

  • Reviewed that test cases and test data make sense.
  • Checked in logs of unit tests CI action that more tests and assertions have run for this PR compared to the current 5.4-dev branch, and that no new PHP deprecation messages were created by the new test cases.
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46723.

@laoneo laoneo self-assigned this Jan 28, 2026
@465645
Copy link

465645 commented Jan 30, 2026

I have tested this item ✅ successfully on 6a1e2c0

Tests look correct based on the regex. Quick question: Should we add a test case for whitespace (e.g., ' true ')? I assume the BooleanRule is intended to be strict and reject untrimmed values, so adding that as a negative test case explicitly would confirm that behavior.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46723.

3 similar comments
@465645
Copy link

465645 commented Jan 30, 2026

I have tested this item ✅ successfully on 6a1e2c0

Tests look correct based on the regex. Quick question: Should we add a test case for whitespace (e.g., ' true ')? I assume the BooleanRule is intended to be strict and reject untrimmed values, so adding that as a negative test case explicitly would confirm that behavior.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46723.

@465645
Copy link

465645 commented Jan 30, 2026

I have tested this item ✅ successfully on 6a1e2c0

Tests look correct based on the regex. Quick question: Should we add a test case for whitespace (e.g., ' true ')? I assume the BooleanRule is intended to be strict and reject untrimmed values, so adding that as a negative test case explicitly would confirm that behavior.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46723.

@465645
Copy link

465645 commented Jan 30, 2026

I have tested this item ✅ successfully on 6a1e2c0

Tests look correct based on the regex. Quick question: Should we add a test case for whitespace (e.g., ' true ')? I assume the BooleanRule is intended to be strict and reject untrimmed values, so adding that as a negative test case explicitly would confirm that behavior.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46723.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46723.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 3, 2026
@richard67 richard67 added this to the Joomla! 5.4.3 milestone Feb 4, 2026
@muhme
Copy link
Contributor

muhme commented Feb 4, 2026

✅ Final test before merge with JBT

  • Seen before: Tests: 920, Assertions: 1423, Skipped: 1.
  • Applied PR with gh pr checkout 46723
  • Seen Tests: 1129, Assertions: 1632, Skipped: 1.

@muhme muhme merged commit bfe4cc7 into joomla:5.4-dev Feb 4, 2026
69 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 4, 2026
@muhme
Copy link
Contributor

muhme commented Feb 4, 2026

Thank you @heelc29 for your contribution. Thank you @brianteeman for support. Thank you @465645 and @brianteeman for testing.

sathwikre pushed a commit to sathwikre/joomla-cms that referenced this pull request Feb 9, 2026
---------

Co-authored-by: Brian Teeman <brian@teeman.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants