Skip to content

Comments

Support '@' and '$' as part of member names#25

Merged
Skarlso merged 1 commit intojoshbuddy:masterfrom
pezra:sigils-in-member-names
May 4, 2017
Merged

Support '@' and '$' as part of member names#25
Skarlso merged 1 commit intojoshbuddy:masterfrom
pezra:sigils-in-member-names

Conversation

@pezra
Copy link

@pezra pezra commented Nov 20, 2013

Allows using paths on documents that use sigils to namespace meta data
or common fields such as JSON-LD

@pezra
Copy link
Author

pezra commented Nov 21, 2013

Json path is, how shall we say, somewhat loosely specified. :-) My reading is that $ and @ are only special when they are the entirety of the token. There doesn't appear to be a way to reference members actually named exactly $ or @ but that seems like a pretty remote use case.

@pezra
Copy link
Author

pezra commented Feb 14, 2014

Is there any chance of this being merged in or should i just close it?

@pezra pezra closed this Feb 18, 2015
@pezra pezra reopened this May 4, 2017
@Skarlso
Copy link
Collaborator

Skarlso commented May 4, 2017

I closed it because it should be fixed in 0.7.0. Could you test it please?

Cheers.

Allows using paths on documents that use sigils to namespace meta data
or common fields such as JSON-LD
@pezra pezra force-pushed the sigils-in-member-names branch from dd12695 to 100f3b4 Compare May 4, 2017 15:06
@pezra
Copy link
Author

pezra commented May 4, 2017

@ was fixed but not $. i updated the code.

@Skarlso
Copy link
Collaborator

Skarlso commented May 4, 2017

Huh, interesting. I really thought I already did this. Huh. I guess I lost in between commits. :/

Cheers man. :)

@pezra
Copy link
Author

pezra commented May 4, 2017

No worries. Super glad to see this gem getting a little attention.

@Skarlso Skarlso merged commit 2d5ada5 into joshbuddy:master May 4, 2017
@Skarlso
Copy link
Collaborator

Skarlso commented May 4, 2017

Word. 👍 :)

@Skarlso
Copy link
Collaborator

Skarlso commented May 4, 2017

I'm gonna cut a new version soon as well.

@pezra
Copy link
Author

pezra commented May 4, 2017

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants