Handle conditions within object child nodes#39
Closed
greyblake wants to merge 1 commit intojoshbuddy:masterfrom
Closed
Handle conditions within object child nodes#39greyblake wants to merge 1 commit intojoshbuddy:masterfrom
greyblake wants to merge 1 commit intojoshbuddy:masterfrom
Conversation
Author
|
P.S. I you decide to merge the PR, can you please publish a new version on rubygems?:) |
Author
|
The specs fail for ruby 1.9.x Is there a chance to merge this PR, @joshbuddy ? |
Skarlso
added a commit
to Skarlso/jsonpath
that referenced
this pull request
May 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the nice gem!
Here is the fix for an issue, I've detected couple hours ago: #38
To make selector be correctly applied for a Hash object, it should be treated slightly differently than an array object: it should not reassign
@_current_node, so current node should be still the same hash.