Skip to content

Comments

Handle conditions within object child nodes#39

Closed
greyblake wants to merge 1 commit intojoshbuddy:masterfrom
greyblake:conditions-for-children-nodes
Closed

Handle conditions within object child nodes#39
greyblake wants to merge 1 commit intojoshbuddy:masterfrom
greyblake:conditions-for-children-nodes

Conversation

@greyblake
Copy link

Hi! Thanks for the nice gem!
Here is the fix for an issue, I've detected couple hours ago: #38

To make selector be correctly applied for a Hash object, it should be treated slightly differently than an array object: it should not reassign @_current_node, so current node should be still the same hash.

@greyblake
Copy link
Author

P.S. I you decide to merge the PR, can you please publish a new version on rubygems?:)

@greyblake
Copy link
Author

The specs fail for ruby 1.9.x

Fetching gem metadata from http://rubygems.org/..............
Resolving dependencies...
Using rake 11.1.2
Using bundler 1.7.6
Using callsite 0.0.11
Using rainbow 2.1.0
Using multi_json 1.11.3
Using minitest 2.2.2
Using phocus 1.1
Using dirge 0.0.5
Using code_stats 0.0.1
NoMethodError: undefined method `spec' for nil:NilClass
An error occurred while installing jsonpath (0.5.8), and Bundler cannot
continue.
Make sure that `gem install jsonpath -v '0.5.8'` succeeds before bundling.
The command "eval bundle install --jobs=3 --retry=3" failed 3 times.

Is there a chance to merge this PR, @joshbuddy ?

Skarlso added a commit to Skarlso/jsonpath that referenced this pull request May 1, 2017
@Skarlso Skarlso closed this May 1, 2017
Skarlso added a commit that referenced this pull request May 2, 2017
* A lot of refactoring and addresses pull #39 and #41.

* Closes #44 and Closes #30.

* Bumped version.

* Updated readme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants