add simplecov test coverage#47
Merged
Skarlso merged 1 commit intojoshbuddy:masterfrom May 2, 2017
Cosaquee:feature/add-test-coverage
Merged
add simplecov test coverage#47Skarlso merged 1 commit intojoshbuddy:masterfrom Cosaquee:feature/add-test-coverage
Skarlso merged 1 commit intojoshbuddy:masterfrom
Cosaquee:feature/add-test-coverage
Conversation
Collaborator
|
Good start. Later on, I can add a badge from coveralls. |
Skarlso
requested changes
May 2, 2017
Rakefile
Outdated
| @@ -1,3 +1,6 @@ | |||
| require 'simplecov' | |||
| SimpleCov.start | |||
Collaborator
There was a problem hiding this comment.
Please add filter for tests.
SimpleCov.start do
add_filter "/test/"
endSince we don't care about coverage for tests.
Skarlso
approved these changes
May 2, 2017
Collaborator
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added simplecov gem to track code coverage.