Eliminating the use of eval step by step#55
Merged
Conversation
Collaborator
Author
|
Test runs have become insanely fast. .............................................
Finished tests in 0.073527s, 612.0201 tests/s, 802.4263 assertions/s.0.07s from something like 0.5... |
Skarlso
commented
May 25, 2017
| each(context, key, pos + 1, &blk) if node == @object | ||
| when /^\[(.*)\]$/ | ||
| handle_wildecard(node, expr, context, key, pos, &blk) | ||
| else |
Collaborator
Author
There was a problem hiding this comment.
I literary found no use for this code segment.
Let it be said here, if anybody has any problems with this missing segment, submit an issue, and I'll investigate use cases for that part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's left.
&&and||