resolving download UI issues#46
Closed
atarkowska wants to merge 1 commit intojoshmoore:restrict-downloadfrom
atarkowska:restrict-download
Closed
resolving download UI issues#46atarkowska wants to merge 1 commit intojoshmoore:restrict-downloadfrom atarkowska:restrict-download
atarkowska wants to merge 1 commit intojoshmoore:restrict-downloadfrom
atarkowska:restrict-download
Conversation
Owner
|
I can't follow what the "hack" is, but I'll trust you to remove that when the time comes 😄 Cherry-picked to 5e1a283 |
Author
|
https://github.com/joshmoore/openmicroscopy/pull/46/files#diff-7bcff1e41a9e76739c322db1ca40c091R2502 It always return false. We need to think how to make it configurable, whether web setting how that was before or server will determine it based on some circumstances, like size etc. |
joshmoore
pushed a commit
that referenced
this pull request
Apr 21, 2015
Add bulk annotations to the main view in OMERO.web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
that should resolve all issues with download restrictions in web UI. please note there is hack in
components/tools/OmeroWeb/omeroweb/webclient/webclient_gateway.canDownloadthat must be removed once server has an option to turn of plate download andwell.canDownloadorplate.canDownloadwill return false. I hope that make sense